New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Cache hasOwnedModifications() #28

Open

unclecheese opened this issue Apr 6, 2020 · 0 comments

unclecheese commented Apr 6, 2020

This relatively expensive method gets called in a number of different contexts:

Update ChangeSetItem (may no longer be necessary with the new event driven approach)
Update CMS actions
Update tree flags

In most modification events, it gets called repeatedly against the same record. Seems like an obvious case for a cached result.

mfendeksilverstripe mentioned this issue

Release 1.x.x regroup #51

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment