Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducer registration issue #89

Open
mfendeksilverstripe opened this issue Sep 13, 2022 · 0 comments
Open

Reducer registration issue #89

mfendeksilverstripe opened this issue Sep 13, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mfendeksilverstripe
Copy link
Collaborator

Looks like the reducer registration is not implemented correctly as it throws an error.

Screen Shot 2022-09-13 at 1 22 02 PM

As far as I can see, this isn't functional error but we should fix that at some point.

Possible fix is to override the reducer instead of registering it.

Replace

Injector.reducer.register('versionedAdmin', combineReducers({
  historyViewer: historyViewerReducer,
}), { force: true });

With

Injector.transform(
  'versioned-history-viewer-override',
  (updater) => {
    updater.reducer('historyViewer', historyViewerReducer);
  }
);
@mfendeksilverstripe mfendeksilverstripe added the bug Something isn't working label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant