Latest entry shows incorrect timestamp on changeless publish

[NightJar]

If a page is not edited when a publish action is undertaken (and nor does it have child content that is edited e.g. elemental blocks), the most recent snapshot entry on the history tab is updated to record the timestamp of the most recent publish action, losing the correct time of when the action it represents was undertaken.

This adversely affects auditable history.

Highly related (and steps to reproduce): silverstripe/silverstripe-versioned#330

[unclecheese]

The publish handler in snapshots uses the most recent ChangeSet as its source of truth. In a changeless publish, this change set will always be populated. Appears to be a symptom of the versioned issue mentioned above.

[unclecheese]

Fix would be to test each change set item and look for at least one CHANGE_MODIFIED or CHANGE_CREATED and if not present, skip the snapshot.

[NightJar]

Have you been able to reproduce this? I have had such great trouble in trying to distill this problem for this report that I'm no longer certain I wasn't just confused in the first place.

I'm thinking to simply close this - it can always be reopened or recreated if I do eventually encounter the problem as described again.

[unclecheese]

Closing this as unable to reproduce.