Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL's get stage appended in fullbuildtask if they are included in urlsToCache() method #159

Closed
lars-lemon8 opened this issue Dec 23, 2022 · 4 comments

Comments

@lars-lemon8
Copy link
Contributor

lars-lemon8 commented Dec 23, 2022

Been digging around a bit, and I have isolated the problem below:

When running the static cache full build task (through the cli), any URLs that are included in urlsToCache() methods in a page class get ?stage=Stage added to the URL. These cannot be processed by the task and will result in the Static Cache Full Build task to end up paused.

So for example, the URL below will end up in the list of URL's to be processed as '/?stage=Stage'

  public function urlsToCache()
    {
        return [HomePage::get()->first()->Link()=>1];
    }

Related issue:
#150

@GuySartorelli
Copy link
Member

Is this actually different to #150? Or are they both symptoms of the same underlying issue?

@lars-lemon8
Copy link
Contributor Author

@GuySartorelli , they certainly are related. I'm not sure they are the same though.

@GuySartorelli
Copy link
Member

@lars-lemon8 If you can't point out how they're different, I think it's easiest to just treat them as the same issue.

@GuySartorelli
Copy link
Member

Closing with the assumption they're effectively the same issue. If you can indicate how they're different I'll reopen.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants