Report title should be underneath actions toolbar

[robbieaverill]

SS 4.1.x-dev, CWP 2.0.x-dev, securityreport 2.0.0

As per silverstripe/silverstripe-reports#100, the actions toolbar should be at the top of the report with content appearing underneath it rather than above it.

cc @clarkepaul

[ScopeyNZ]

FYI we did this in bringyourownideas/silverstripe-maintenance but as it's part of a GridField we chose to implement a GridFieldHtmlFragment GridField component:

https://github.com/bringyourownideas/silverstripe-maintenance/blob/master/src/Forms/GridFieldHtmlFragment.php

[robbieaverill]

Yeah this change needs to be made in the core silverstripe/reports module first IMO

[muskie9]

Would this require pulling over the class referenced, or would this be better suited in something like framework as a component for re-use? Happy to pull it into this module or reports if it doesn't make sense in framework.

[robbieaverill]

That example class was created because there wasn't something already available to do it in core. What do you think? I think we should move conversation to silverstripe/silverstripe-reports#100 initially anyway, but we should aim to put as much of the customisation into framework -> reports -> here as possible, since this is a reusable pattern that we're trying to fix

[muskie9]

I think that makes sense. This is something that expects to utilize functionality that should be available already. The framework ticket referenced from the reports ticket has some references to the gridfield title that I was going to ask about as well, so it seems this ticket will be handled in time once those are sorted.