Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select all checkbox doesn't have a visuable label anymore #180

Open
raissanorth opened this issue Sep 7, 2018 · 2 comments
Open

Select all checkbox doesn't have a visuable label anymore #180

raissanorth opened this issue Sep 7, 2018 · 2 comments

Comments

@raissanorth
Copy link

2c40a16 removed the title for the select all checkbox, to be precise:

 <% _t('GRIDFIELD_BULK_MANAGER.SELECT_ALL_LABEL', $Select.Label) %>

This causes the checkbox to look out of place - or a misrendered checkbox -, see e.g. the screenshot from the Comments tab:

image

While it is not hard to add this back into the label, the spacing causes some issues since 'Select all' would wrap over two lines...

image

Tried fixing this with white-space: no-wrap which caused the text to be disaligned...

image

Sorry don't have more time to look into this today, but wanted to capture this somehow.

@colymba
Copy link
Collaborator

colymba commented Sep 7, 2018

Yeah I know what you mean...
All would probably be solved if we have the checkboxes on the left of the gridfield and the select-all box in the gridfield header.

@robbieaverill
Copy link
Contributor

+1 for moving it to the left. I think in that case not having a label would be fine, because most web UIs that have a select all feature would look like that anyway so people would usually understand what it does. We'd still need to provide an aria label though for screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants