-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Deprecation::withNoReplacement() #11382
Labels
Comments
This was referenced Sep 17, 2024
@GuySartorelli Note that the fluent PR was merged with |
This was referenced Sep 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Deprecation::withNoReplacement() is a somewhat misnamed method in that while it's used for to wrap suppressing deprecation notices for classes/methods with no replacement, it's also used to suppress those notices when calling a deprecated method or creating a deprecated class.
This is somewhat confusing and it would be better if it was simply renamed
Acceptance criteria
PRs
The text was updated successfully, but these errors were encountered: