Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for MySQL 5 in CMS 6 #11292

Closed
GuySartorelli opened this issue Jun 25, 2024 · 3 comments
Closed

Drop support for MySQL 5 in CMS 6 #11292

GuySartorelli opened this issue Jun 25, 2024 · 3 comments
Assignees
Milestone

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Jun 25, 2024

MySQL 5 went EOL in 2023. We should stop supporting it.

Acceptance Criteria

  • Any mention of MySQL 5 in the docs on the 6 branch is either removed or updated
  • Any code which specifically handled differences between MySQL 5 and 8 is updated to only handle 8
  • CI runs for testing MySQL 5 no longer run for CMS 6
  • The changelog calls out this change and reminds people that we support and test against the latest LTS releases of MySQL and MariaDB

PRs

@NightJar
Copy link
Contributor

Is there any code that is even MySQL specific? Enums.
Is there any code that is even MySQL 5 specific? I don't even know what that looks like, they both parse SQL.
There was that one gotcha with the output of some introspection query being different... but that's already patched.

Is there any impact to MariaDB support with a change like this?

@GuySartorelli
Copy link
Member Author

Is there any code that is even MySQL 5 specific?

I know some of the tests run conditionally on what version of mysql is being run, so possibly.

Is there any impact to MariaDB support with a change like this?

There shouldn't be.

@GuySartorelli
Copy link
Member Author

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants