Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changetracking doesn’t appear to be working correctly for inline editing #1287

Open
2 tasks done
kinglozzer opened this issue Dec 3, 2024 · 1 comment
Open
2 tasks done

Comments

@kinglozzer
Copy link
Member

Module version(s) affected

5.3.0

Description

When inline editing elements, changetracking doesn’t appear to work. If you edit an element’s title/content, the “Save” & “Save and Publish” buttons don’t get highlighted, and navigating away from the page doesn’t open the warning alert about unsaved changes.

This appears to be a regression, as it functions as expected in 5.2

How to reproduce

Create a standard “Content” block, add some content, save & publish.

Edit the title or content, note that the save buttons aren’t highlighted.

Close the tab, refresh the page, or click a link to navigate away - note that the alert to warn about losing unsaved changes doesn’t appear.

Possible Solution

No response

Additional Context

No response

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
@guci0
Copy link

guci0 commented Dec 14, 2024

Same story here. EDIT: Latest working 5.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants