From 8407c4ee37c77288eae31ab7d29b0892a2e79d7d Mon Sep 17 00:00:00 2001 From: Sabina Talipova Date: Thu, 19 Oct 2023 16:16:01 +1300 Subject: [PATCH] MNT Remove TODO comments --- client/src/containers/CampaignAdmin/CampaignAdmin.js | 1 - client/src/containers/CampaignAdmin/CampaignAdminItem.js | 2 -- src/CampaignAdmin.php | 5 ----- 3 files changed, 8 deletions(-) diff --git a/client/src/containers/CampaignAdmin/CampaignAdmin.js b/client/src/containers/CampaignAdmin/CampaignAdmin.js index b12cbd77..b65c2b30 100644 --- a/client/src/containers/CampaignAdmin/CampaignAdmin.js +++ b/client/src/containers/CampaignAdmin/CampaignAdmin.js @@ -92,7 +92,6 @@ class CampaignAdmin extends Component { // NOOP - Lazy loaded in CampaignAdminList.js break; case 'edit': - // @todo - Lazy load in FormBuilderLoader / GridField breadcrumbs.push({ text: title, href: this.getActionRoute(id, view), diff --git a/client/src/containers/CampaignAdmin/CampaignAdminItem.js b/client/src/containers/CampaignAdmin/CampaignAdminItem.js index 97c09da9..82fbd0b1 100644 --- a/client/src/containers/CampaignAdmin/CampaignAdminItem.js +++ b/client/src/containers/CampaignAdmin/CampaignAdminItem.js @@ -114,8 +114,6 @@ class CampaignAdminItem extends Component { const badge = {}; const { campaign, item } = this.props; - // @todo customise these status messages for already-published changesets - // Change badge. If the campaign has been published, // don't apply a badge at all if (campaign.State === 'open') { diff --git a/src/CampaignAdmin.php b/src/CampaignAdmin.php index b8bc3c5a..49cd63ce 100644 --- a/src/CampaignAdmin.php +++ b/src/CampaignAdmin.php @@ -118,7 +118,6 @@ public function getClientConfig() return array_merge(parent::getClientConfig(), [ 'reactRouter' => true, 'form' => [ - // TODO Use schemaUrl instead 'EditForm' => [ 'schemaUrl' => $this->Link('schema/EditForm') ], @@ -601,9 +600,6 @@ public function campaignEditForm($request) } /** - * @todo Use GridFieldDetailForm once it can handle structured data and form schemas - * @todo move to FormBuilder - * * @param int $id * @return Form */ @@ -684,7 +680,6 @@ public function campaignCreateForm($request) /** * Build create form - * @todo Move to form builder * * @return Form */