-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern Library not working on Windows10/git-bash #465
Comments
Can confirm. |
Looking through the error log I see references to #426 - perhaps the same cause. |
Also in MacOS:
|
Although seems to be a different error, complaining about missing configuration files - which there seems to be no documentation about setting up. |
Did you run |
Things work better now, thanks @chillu At this point it's bringing me to a loading webpage, but then that page is filled with errors instead of patterns. My (shell) console is loaded up with ERRORs about failed parsing due to unexpected characters in the font files, which is reflected the resulting page served to the browser. This could be an unstable head thing though, unsure.
|
So, this actually extends further than here (checking out the pattern library) - building the UI for admin also does not complete successfully on Windows. |
Good news @wernerkrauss - Al Twohill has fixed this for us in silverstripe/webpack-config#24 :) Ingo's caveat at #465 (comment) is still important though, as is adapting the commands to run in a windows shell where applicable. But it builds, and you can run it :) |
I wouldn't describe that as a caveat, but a necessary step in order to get the pattern library running. If you think it should be a workaround of some sort/caveat, perhaps we need to make it clearer in the documentation? It's the same for macOS users too of course |
I described it as a 'caveat' here as there has already been confusion enough to mentioned it above. I've not read the recent documentation, so didn't want to comment directly to that effect. If it's not a prominent in the docs (for pattern-lib), then it should be - otherwise it leads to confusion such as above and #426 |
I don't think #426 is related, but the documentation I could find via Google definitely doesn't mention needing to install dev deps in each of these modules. I'll raise a new issue to ensure it gets updated. |
Hmm, description indicated that it might be in
But a new issue about docs sounds the best solution really :) |
We've got a separate issue for handling the doc update #586 to include the info as per Ingo's comment. From @NightJar, I understand that this is now building on Windows. I'll close this for now, but do let me know if it needs to be reopened. |
I installed SS4.1.0 stable and tried out the pattern library. It didn't work.
npm is V 6.11.0
The text was updated successfully, but these errors were encountered: