Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sass-lint for stylelint #1437

Closed
emteknetnz opened this issue Jan 11, 2023 · 1 comment
Closed

Change sass-lint for stylelint #1437

emteknetnz opened this issue Jan 11, 2023 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 11, 2023

sass-lint is abandoned - its recommended replacement is stylelint

This was originally upgraded as part of the change to the frontend build stack, though this was later reverted as stylelint is currently non-functional due to the lack of stylelintrc.yml files

We need to change all the sass-lint.yml files in modules to stylelintrc.yml files instead i.e. https://dev.to/stories_of_ren/switching-from-sass-lint-to-stylelint-5f8c

This should probably only be done for CMS5

Related

ACs

  • Update silverstripe/webpack-config from sass-lint to stylelint
  • yarn update all modules that use webpack-config
  • Add stylelintrc.yml files to modules
  • Remove sass-lint.yml files from modules
  • Linting passes without errors or warnings on all core and supported modules
@GuySartorelli
Copy link
Member

Closing as duplicate of silverstripe/webpack-config#69

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants