Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page and PageController show up in IDEs as valid classes #9

Open
2 tasks
dhensby opened this issue Feb 14, 2018 · 3 comments
Open
2 tasks

Page and PageController show up in IDEs as valid classes #9

dhensby opened this issue Feb 14, 2018 · 3 comments

Comments

@dhensby
Copy link
Contributor

dhensby commented Feb 14, 2018

When using an IDE's "find class" feature, Page and PageController will often match two different files (the one in the project and the one in recipe-cms).

Please can we rename the files to have an extension like .tmpl or whatnot so that IDEs don't recognise them as PHP classes.

When we copy the files into projects we can copy and rename them instead to just copying them.

Related PRs

@chillu
Copy link
Member

chillu commented Feb 18, 2018

+1 - wanna send a PR?

@dhensby
Copy link
Contributor Author

dhensby commented Feb 22, 2018

OK - so we need a PR to silverstripe/recipe-plugin to strip the .tmpl extension off files first.

@tractorcow
Copy link

Yep thanks for your work on this @dhensby I like the idea and think it's working well. Only one last thing on silverstripe/recipe-plugin#5 to ensure the base project is renamed and we're golden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants