Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some early checks for missing basic requirements #77

Open
edwilde opened this issue Aug 7, 2023 · 1 comment
Open

Add some early checks for missing basic requirements #77

edwilde opened this issue Aug 7, 2023 · 1 comment

Comments

@edwilde
Copy link
Contributor

edwilde commented Aug 7, 2023

If the action is added to a repo without the proper files / config in place, then the error messaging is pretty cryptic when it fails.

Screen Shot 2023-08-08 at 9 10 14 AM

This will happen if the repo is missing a phpunit config or phpcs config (and maybe php version in the composer.json, I am not sure).

It would be real nice if these super, obvious, basic things could be checked early on in the generate matrix task and display a helpful failure message.

Or maybe fail the task if the matrix is empty with some suggestions?

Screen Shot 2023-08-08 at 8 57 55 AM

Making stuff Ed proof is good 🤡

@GuySartorelli
Copy link
Member

Hi Ed,

That sounds like a good idea - but it'll be pretty low on the list of priorities right now. If you're willing to raise a PR adding these checks and dev-friendly messages we'd be happy to review it but otherwise it could be quite a while before this is prioritised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants