Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related pages linking feature has a bug with publishing pages (SS4) #324

Open
Veronica-davidraj opened this issue Mar 13, 2023 · 2 comments

Comments

@Veronica-davidraj
Copy link

Steps to reproduce:

-Create page A and page B
-Link both pages via related pages tab

When testing the scenario above we found a security issue with the related pages tab.

Page B(Draft) gets attached to Page A(Published) via the related pages tab then Page B automatically gets published when Page A is published again.

@maxime-rainville
Copy link

@Veronica-davidraj Thanks for reaching out. For future reference, if you come across an issue you think as security implications, please email [email protected] first. You can find more information about Reporting security issues is our official doc.

In this specific case, we agree this is a bug. We don't think it's worth treating it as a security issue however.

You would need to have CanView permissions on Page B to view its content even after publishing it. Presuming you have CanView permission on Page B without CanEdit, you would still be able to view the draft content. You could just take that draft content and copy-paste it on a page you can publish.

@maxime-rainville
Copy link

The problem here is that "Related pages" is a $owns relation. That doesn't make much sense.

My guess is this something we could ship in a minor release, but probably not in a patch release. Would we be comfortable sneaking this one into 4.13 post beta? If not, it will have to stay like this in CMS 4, and will only be shipped in CMS5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants