Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static error pages have incorrect base tag #84

Open
dnsl48 opened this issue Oct 2, 2019 · 1 comment
Open

Static error pages have incorrect base tag #84

dnsl48 opened this issue Oct 2, 2019 · 1 comment

Comments

@dnsl48
Copy link
Contributor

dnsl48 commented Oct 2, 2019

Somewhat relevant: silverstripe/silverstripe-errorpage#20

However, we may need to remove the static error pages altogether from snapshots so that they may be regenerated later on on demos.

@chillu
Copy link
Member

chillu commented Oct 2, 2019

The effect is that any "page not found" or "server error" page looks unstyled, and throws security issues. If we fix the server errors, that page won't appear, but we should definitely fix it for the "page not found" case anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants