Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JS deps - react-dnd #335

Closed
1 task
emteknetnz opened this issue Nov 19, 2024 · 1 comment
Closed
1 task

Upgrade JS deps - react-dnd #335

emteknetnz opened this issue Nov 19, 2024 · 1 comment
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 19, 2024

Split from #308

Update react-dnd and react-dnd-html5-backend to ^16 in the following modules

  • silverstripe/admin
  • silverstripe/asset-admin
  • dnadesign/silverstripe-elemental

New issues created

Acceptance criteria

  • react-dnd and react-dnd-htm5-backend are upgraded to their latest major versions
@emteknetnz
Copy link
Member Author

In LinkField we implemented drag and drop using dnd-kit instead due to it being more maintained and not completely breaking silverstripe/silverstripe-linkfield#166

I'm going to recommend that we don't bother upgrading react-dnd, and instead switch everything over to dnd-kit instead. From memory we talked about doing this at some point offline at the time we did the linkfield work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant