You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While peer reviewing silverstripe/silverstripe-framework#11066 I noticed that the vast majority of extension config is in yml, will a small amount in php using private static $extensions.
It would be preferable to if ALL extension config was in a single place rather than two possible places. This make it easier to search for extensions e.g. filter by yml files in vscode
We should standarise putting it all in yml because:
The vast majority of it is already there
We'll never be able to use PHP only, because many extensions are in optional modules which can only be added via yml i.e. the class having the extension added to it isn't aware of the optional module.
The text was updated successfully, but these errors were encountered:
I think that extension config that is inherently necessary for a class to function as expected should be in the class itself.
e.g. SiteTree is always expected to be versioned, so we have the versioned extension declared in the class directly.
This implies those extensions should never be removed - whereas extensions added via yaml should be allowed to be removed without negative impacts.
Do we need to document this pseudo-rule somewhere so it becomes more standard? I think I tend to agree with you Guy but it only makes sense if it's accurate.
While peer reviewing silverstripe/silverstripe-framework#11066 I noticed that the vast majority of extension config is in yml, will a small amount in php using
private static $extensions
.It would be preferable to if ALL extension config was in a single place rather than two possible places. This make it easier to search for extensions e.g. filter by yml files in vscode
We should standarise putting it all in yml because:
The text was updated successfully, but these errors were encountered: