Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMS badges for Embargo & Expiry status #26

Open
chrispenny opened this issue Jul 20, 2018 · 5 comments
Open

Add CMS badges for Embargo & Expiry status #26

chrispenny opened this issue Jul 20, 2018 · 5 comments

Comments

@chrispenny
Copy link
Member

chrispenny commented Jul 20, 2018

It has been decided that Core will not support (non-core) status flags with text displayed (they will currently overlap). Instead, it is suggested that you use the new "badge" system.

We should remove our status flag text values, and add badges.

@edwilde
Copy link

edwilde commented Oct 3, 2023

I would assume that is what is also causing the overlapping text?

See below for an example from CMS 4.13 (heavily redacted, sorry)

de2b952b-d914-4e4e-966a-b1f040fdaf36

@chrispenny
Copy link
Member Author

@edwilde yup, that's correct. All of these messages need to be moved to Badges (or something else appropriate that has official CMS support).

@edwilde
Copy link

edwilde commented Oct 3, 2023

It looks like the ones in the CMS (v4) are just the same thing but with CSS backgrounds?

Screen Shot 2023-10-04 at 10 03 42 AM

@chrispenny
Copy link
Member Author

The "badges" (if I recall correctly) are part of the page edit form - they're not part of the Site Tree list.

EG: Fluent uses badges for showing language:
Screenshot 2023-10-04 at 11 22 40 AM

Not quite as nice, since you can't see these while browsing the "overview" of pages presented in our Site Tree list, but this is where I was pointed to by the product and UX team when I originally raised this issue of overlapping statuses with them.

Definitely open to other suggestions.

@edwilde
Copy link

edwilde commented Oct 3, 2023

Ahh, ok...so there is a proper way and a workable way. In this case the client definitely wants them in the sitetree listing.

I guess maybe we do a quick fix to avoid the overlapping issue by adding a background colour and leave this open to add the badges (as well maybe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants