Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS Dependency? #17

Closed
phptek opened this issue Feb 19, 2024 · 1 comment
Closed

CMS Dependency? #17

phptek opened this issue Feb 19, 2024 · 1 comment

Comments

@phptek
Copy link

phptek commented Feb 19, 2024

I've been using a fork of this module in a framework-only project for some months without issue. I'd like to remove the forked module from my codebase, but if I install this module into my framework-only project with Composer, I get a bunch of CMS-related packages and my test suite and functionality obviously falls to bits.

As far as I can tell looking at the code, there's no need for the silverstripe/cms package at all. It's referenced in composer.json and phpunit.xml.dist (the latter can be replaced by a framework-only bootstrap of course). So is there any other reason why a CMS dependency is used? Could the module get away with silverstripe/framework or silverstripe/admin in its place?

@mfendeksilverstripe
Copy link
Contributor

Fixed in #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants