Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set project purpose on project page #969

Merged
merged 9 commits into from
Jul 24, 2024
Merged

set project purpose on project page #969

merged 9 commits into from
Jul 24, 2024

Conversation

psh0078
Copy link
Collaborator

@psh0078 psh0078 commented Jul 17, 2024 •
edited by rmunn
Loading

fixes #931.

Screenshots:

image

image

image

image

@psh0078 psh0078 self-assigned this Jul 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5dfb561. ± Comparison against base commit 1539fbb.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 17, 2024 •
edited
Loading

C# Unit Tests

53 tests  ±0   53 ✅ ±0   6s ⏱️ -1s
10 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 5dfb561. ± Comparison against base commit 1539fbb.

♻️ This comment has been updated with latest results.

@psh0078
Copy link
Collaborator Author

psh0078 commented Jul 18, 2024 •
edited
Loading

I am stuck on this error where modal becomes null when trying to be closed.

Screenshot 2024-07-17 152827

  • @rmunn suggested that in FormModal.svelte I make modal.close() accept null by turning it into modal?.close().

@psh0078 psh0078 marked this pull request as ready for review July 18, 2024 03:46
rmunn
rmunn requested changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple changes needed, then this should be good to go,

backend/LexBoxApi/GraphQL/ProjectMutations.cs Outdated Show resolved Hide resolved
frontend/src/routes/(authenticated)/project/create/+page.svelte Outdated Show resolved Hide resolved
@psh0078 psh0078 requested a review from rmunn July 18, 2024 04:57
rmunn
rmunn approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Good work.

@rmunn rmunn merged commit 1930cfd into develop Jul 24, 2024
14 checks passed
@rmunn rmunn deleted the feat/set-purpose-on-project-page branch July 24, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmunn rmunn rmunn approved these changes

Assignees

@psh0078 psh0078

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to set project purpose on project page
2 participants
@psh0078 @rmunn