Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invite users to lexbox when added to org #940

Merged
merged 19 commits into from
Jul 23, 2024

Conversation

psh0078
Copy link
Collaborator

@psh0078 psh0078 commented Jul 9, 2024

Fixes #930

This PR implements ability to invite users to register account on Lexbox when added to organization. After signing up, the user will automatically be added to the organization.

  • Moved ExtractNameAndAddressFromUsernameOrEmail to UserService.cs so that both OrgMutations.cs and ProjectMutation.cs can use it.
  • Created SendCreateAccountEmail for both project and org.
  • Added a checkbox that invites users when not found in AddOrgMemberModal.svelte. Basically, if you want to invite new user, you need to tick the invite checkbox.
    image

@psh0078 psh0078 added the ASP.NET owner: Kevin label Jul 9, 2024
@psh0078 psh0078 self-assigned this Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

C# Unit Tests

53 tests  ±0   53 ✅ ±0   5s ⏱️ ±0s
10 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7172811. ± Comparison against base commit 3b5c99a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 15, 2024

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 7172811. ± Comparison against base commit 3b5c99a.

♻️ This comment has been updated with latest results.

@psh0078 psh0078 marked this pull request as ready for review July 16, 2024 08:18
@psh0078 psh0078 requested a review from hahn-kev July 16, 2024 08:19
@psh0078 psh0078 removed the ASP.NET owner: Kevin label Jul 16, 2024
…. Add css variable justify-actions to Modal to control the alignment of the extraActions slot
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, I tested it out and it works just how we want it to.

There's some minor code style changes I'd like to request.

backend/LexBoxApi/GraphQL/OrgMutations.cs Outdated Show resolved Hide resolved
backend/LexBoxApi/Services/EmailService.cs Outdated Show resolved Hide resolved
backend/LexBoxApi/Services/Email/EmailTemplates.cs Outdated Show resolved Hide resolved
backend/LexBoxApi/Services/EmailService.cs Outdated Show resolved Hide resolved
backend/LexBoxApi/Services/EmailService.cs Outdated Show resolved Hide resolved
@psh0078 psh0078 requested a review from hahn-kev July 17, 2024 03:58
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@psh0078 psh0078 merged commit 1539fbb into develop Jul 23, 2024
14 checks passed
@psh0078 psh0078 deleted the feat/invite-users-to-lexbox-when-added-to-org branch July 23, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invite users to lexbox when adding to an org
2 participants