close fwdata file when leaving the editor #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the group that the project is closed.
rmunn
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
I don't see the code that calls OnDisconnectedAsync when navigating away, but I assume that's already set up in the SignalR configuration somewhere (I don't yet have any experience with SignalR) so I'll assume it's working correctly. My only concern is to find out whether the IMemoryCache.Remove() call will actually trigger post-eviction callbacks (see below). If it does, then this looks good to me.
# Conflicts: # backend/FwDataMiniLcmBridge/FwDataBridgeKernel.cs # frontend/viewer/src/App.svelte # frontend/viewer/src/ProjectView.svelte
…d by dynamically rendering it with #if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #912
there's now a home button on the editor, when you click it the fwdata file will be closed to let you open the project in flex. If you have the project open on another tab it will be sent home with a message about why they were navigated away.