From 8a3e5d51bbe886a70ad95f11112965038431dbaa Mon Sep 17 00:00:00 2001 From: briskt <3172830+briskt@users.noreply.github.com> Date: Fri, 23 Feb 2024 09:04:28 -0700 Subject: [PATCH 1/3] fix copy-paste error and move the image name into a variable --- .github/workflows/test-and-publish.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test-and-publish.yml b/.github/workflows/test-and-publish.yml index c04a33c6..45564475 100644 --- a/.github/workflows/test-and-publish.yml +++ b/.github/workflows/test-and-publish.yml @@ -3,6 +3,9 @@ name: Test and Publish on: push: +env: + IMAGE_NAME: ${{ vars.DOCKER_ORG }}/ssp-base + jobs: tests: name: Tests @@ -35,7 +38,7 @@ jobs: id: meta uses: docker/metadata-action@v5 with: - images: ${{ vars.DOCKER_ORG }}/idp-id-broker + images: $IMAGE_NAME - name: Build and push Docker image uses: docker/build-push-action@v5 with: From c88fa93eba309b500010f26f92506f69df9e7a84 Mon Sep 17 00:00:00 2001 From: briskt <3172830+briskt@users.noreply.github.com> Date: Fri, 23 Feb 2024 09:20:54 -0700 Subject: [PATCH 2/3] use quotes on the image name variable --- .github/workflows/test-and-publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-and-publish.yml b/.github/workflows/test-and-publish.yml index 45564475..11856649 100644 --- a/.github/workflows/test-and-publish.yml +++ b/.github/workflows/test-and-publish.yml @@ -38,7 +38,7 @@ jobs: id: meta uses: docker/metadata-action@v5 with: - images: $IMAGE_NAME + images: "$IMAGE_NAME" - name: Build and push Docker image uses: docker/build-push-action@v5 with: From 7c46acdf131cc473a73aed32e3a1e1ad1a086841 Mon Sep 17 00:00:00 2001 From: briskt <3172830+briskt@users.noreply.github.com> Date: Fri, 23 Feb 2024 09:25:47 -0700 Subject: [PATCH 3/3] use context syntax for image name --- .github/workflows/test-and-publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-and-publish.yml b/.github/workflows/test-and-publish.yml index 11856649..01250e19 100644 --- a/.github/workflows/test-and-publish.yml +++ b/.github/workflows/test-and-publish.yml @@ -38,7 +38,7 @@ jobs: id: meta uses: docker/metadata-action@v5 with: - images: "$IMAGE_NAME" + images: ${{ env.IMAGE_NAME }} - name: Build and push Docker image uses: docker/build-push-action@v5 with: