Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: refactored structureOutput with single reduce #592

Merged
merged 3 commits into from
Oct 26, 2023
Merged

perf: refactored structureOutput with single reduce #592

merged 3 commits into from
Oct 26, 2023

Conversation

Connormiha
Copy link
Contributor

A little simplification with single reduce instead of filter+forEach. And startsWith instead of indexOf.

@zbjornson
Copy link
Collaborator

Looks great, thanks. CI will complain in a moment that there's no changelog entry. Can you add one please?

SimenB
SimenB approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit c0f2297 into siimon:master Oct 26, 2023
10 checks passed
@SimenB
Copy link
Collaborator

SimenB commented Dec 15, 2023

https://github.com/siimon/prom-client/releases/tag/v15.1.0

@lholmquist lholmquist mentioned this pull request Jun 5, 2024
Closed
@muyinatech muyinatech mentioned this pull request Sep 18, 2024
Closed
@doperiddle doperiddle mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Connormiha @zbjornson @SimenB