-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deconstructSigs and hg38 #27
Comments
Worried that the object And it actually not passed here: https://github.com/sigven/pcgr/blob/master/src/R/pcgrr/R/mutational_signatures.R#L80-L85 |
Hi Vlad, Sigve |
Btw: would you be able to share your calls (VCF)? As a sanity check for my fix. |
Hey, sure, attaching the bundle with VCF, CNV calls, and a toml. Note that will not pass the validation, so my toml specified validation disabled. |
And while we are on it, attaching one more. This one crashes with the following error:
Again, does not pass validation, so might be something wrong with the VCF. But I can't reproduce the error by running |
Hi again Vlad, I did not see any CNV calls in your zip, but I believe I have now fixed the bugs you encountered in 0.6.1 (deconstructSigs for hg38, and an ASCII-encoding issue in the vcf2tsv transformation (the lack of proper encoding caused a mistake for "Café-au-lait_macules_with_pulmonary_stenosis":-)) Output files for SNVs/InDels in COLO829 can be downloaded here. A couple of comments to your run and config (not sure how carefully this was configured, but anyways):
|
Sigve, thanks for the reply, really appreciate the quick fixes. There were two zip files that I attached above, in 2 different comments. COLO829__COLO829T-somatic.zip is the VCF representing the mut sig error, for the original issue. It's tumor somatic alls and include a CNV file. The next one - COLO829__COLO829T-normal.zip - which represents the encoding issue - has the germline calls, that's why it appears like tumor-only. Are absolutely right about the target size, in fact PCGR warned me about that and stopped running, so I changed the value back to 36 for the rerun (nice error handling btw!), however for some reason I accidentally sent you the bad version of the toml. Anyway, thanks for pointing out! Looking forward to the new commits, will pull and rerun my samples! |
Speaking about germline, should we be running this instead? https://github.com/sigven/pcgr_predispose |
Hi Sigve, I turned off the input validation and ran the tool, and facing somewhat similar issue , exact error mentioned below: 2018-05-04 07:10:41 [INFO] deconstructSigs normalization method ('tri.counts.method'): default I have turned off input validation as it was not processing the vcf file and flagging below error: Any help/suggestion would be appreciated. Thanks |
Sigve, On this again:
I attached 2 different zip files above. Sorry for making it confusing. The first one, COLO829__COLO829T-somatic.zip, was to illustrate the original issue on the mutational signatures. It's tumor somatic alls and include a CNV file. The next zip file - COLO829__COLO829T-normal.zip - is another one, and represents an unrelated encoding issue. That file has the germline calls only and lacks the CNV file. |
Hi Vlad and @akhtar4ever , The mutational signatures bug (grch38) that you were both observing should how have been fixed (0.6.2). Akhtar; your other error (the VCF validation error) has been filed two times previously (issues #28, #22). I am afraid the MuTect2 output VCF does not adhere to the VCF restrictions, so in this case you should turn VCF validation off. Vlad: you are correct regarding the interpretation of germline calls, for this I am developing the predisposition report engine. Not that this is somewhat preliminary, work in progress, with a number of enhancements coming. Either way, your test case results (COLO829), with somatic and predisposition reports can be downloaded here |
Thanks Sigve, Thanks for the fixes. 2018-05-11 07:26:59 [INFO] Identifying weighted contributions of known mutational signatures using deconstructSigs Any help/suggestion would be appreciated. Thanks |
Ah, I see. I need your input (VCF + the config file) to do error-checking. Would you be able to share that with me? BTW: Have you specified the correct build (GRCh37/GRCh38) for your input? |
Hi Sigve, I have specified the build, command used is: |
Hi Akhtar, |
Hi Sigve, Apologies for the delay. Attached the vcf and config file. Thanks |
Hi Sigve, The files were not getting uploaded, so zipped them. for_pcgr_share.zip Let me know if anything else is required. Thanks |
Hi Akhtar, I asked previously if you had specified the correct build (GRCh37/GRCh38) for your input, making sure that the build you specify is matching your input data. In your test case ( I used GRCh37, and it ran with no errors. You can see from line 4 in your VCF that Although PCGR in principle could make an assembly check for the input, I believe the users should carry the main responsibility for making sure that there is a correspondence between the build/assembly that is specified and the actual build/assembly of the input files. It's also highly appreciated if this matter is interrogated before any issues are filed. kind regards, |
Thanks a lot Sigve for your findings. Appreciate your efforts and quick response. Thanks |
Hi Sigve,
Thanks for the new version and especially hg38 support! Worked fantastic, however when tried to enable
mutational_signatures
, I ran into this issue:Not sure, but this might to be coming from deconstructSigs not fully supporting hg38? There is a fork that has this fix: temizna/deconstructSigs@596cec6
Maybe as a quick fix, PCGR could pull the fixed deconstructSigs branch rather than the main one. Though no rush for us in UMCCR - currently we generate mutational signature separately. But would be nice to have all in PCGR in the future!
Vlad
The text was updated successfully, but these errors were encountered: