Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make targets expiry very long #126

Closed
jku opened this issue May 23, 2024 · 5 comments
Closed

Make targets expiry very long #126

jku opened this issue May 23, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@jku
Copy link
Member

jku commented May 23, 2024

There's currently open signing events for both root and targets. We could just sign them ... but how about this as a plan:

  • set targets expiry period to very long like snapshot (in staging it's 10 years)
  • keep root expiry at 3 months (this is more frequent than prod just to get some experience)

This should get us the same advantages (mainly regular test for root key existence) with signing events that are smaller (so easier to review)

I will make a change in one of the open signing events to implement this: feel free to voice a differing opinion though.

CC @kommendorkapten @joshuagl @mnm678 @haydentherapper

@jku jku added the enhancement New feature or request label May 23, 2024
@jku
Copy link
Member Author

jku commented May 23, 2024

To be clear, I intend to propose this for production too once that time comes

@kommendorkapten
Copy link
Member

I totally agree on changing the targets expiration to a long time.

@joshuagl
Copy link
Member

There's currently open signing events for both root and targets. We could just sign them ... but how about this as a plan:

* set targets expiry period to very long like snapshot (in staging it's 10 years)

Isn't this repo staging?

* keep root expiry at 3 months (this is more frequent than prod just to get some experience)

This should get us the same advantages (mainly regular test for root key existence) with signing events that are smaller (so easier to review)

And, importantly, no real loss in security, right?

I agree with the decision to extend the expiry period of targets metadata to a long time.

I think it's worth capturing the rationale somewhere in the project's documentation, as this may appear counterintuitive on first examination.

@jku
Copy link
Member Author

jku commented May 24, 2024

Isn't this repo staging?

Yeah my phrasing was not ideal: I just meant that I used the same expiry period value as snapshot since the logic for both is kind of the same: We want to sign these files but think there is no need for them to expire in our case so chose the value 10 years.

And, importantly, no real loss in security, right?

Yes, this is my understanding: There is no scenario where offline targets resigning (without key rotations) makes the repository more secure.

Short documentation makes sense: it should capture at least:

  • chosen number of signers
  • expiry and signing period lengths for different roles

@jku
Copy link
Member Author

jku commented May 30, 2024

This is now done. #129 exist for documenting rationale

@jku jku closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants