Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage GitHub Releases rather than tags #254

Open
haydentherapper opened this issue Mar 11, 2024 · 0 comments
Open

Leverage GitHub Releases rather than tags #254

haydentherapper opened this issue Mar 11, 2024 · 0 comments

Comments

@haydentherapper
Copy link
Collaborator

Currently we cut new package releases when a tag is created. The problem is that tags can be created based on commits that are not off main, meaning they are unreviewed. #250 was an attempt at checking if the commit that tag is based on exists on main, but as discussed, there are a few issues with this approach.

@kommendorkapten and @woodruffw proposed using GitHub releases instead, which can require review from maintainers before publishing a release. We can then update the release workflows to trigger off releases:published instead of tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant