Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes translations for screen readers #5780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tairosonloa
Copy link

@tairosonloa tairosonloa commented Mar 30, 2024

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
    • iPhone 13 iOS 17.3.1

Description

Spanish (ES) translations includes some terms like "amigxs" among others, that following with this example, "amigxs" is
a gender-inclusive way to write "amigos" ("friends" in Spanish).

This happens because in Spanish, and in opposition to English, most nouns have gender, so certain words can be written in masculine (usually ending in a letter "o") or feminine (usually ending in a letter "a"). Therefore, some Spanish-spoken people that doesn't identify themselves in the binary (masculine or feminine) gender started to replace those "o" and "a" letters with an "x" on wrote text, in an attempt to make them more inclusive to anyone.

However, although there are good intentions in this practice, it ends being less inclusive. The main problem is that those "x" substitutions of "o" and "a" are impossible to pronounce in Spanish, as they are substituting a vowel by a consonant. Therefore, screen readers are unable to read those texts, and makes visual-impaired people harder to use the app without help.

iOS is an ecosystem that always has focused on accessibility, and Signal is an app that is intended to be easy and accessible to all kind of people, so I think this is a good change for the community. Specially, because we'll allow those visual-impaired people that currently are unable to use the app to start having a more secure and privately way to communicate with peers :)

So my change is as follows: I changed all those "x" ending words to their "o" version, that is the masculine one, but also, the common noun gender to use in Spanish when you don't know / cannot know the gender of the person to who is referring or affecting that noun. Also, it's the only grammatically/semantically accepted (correct) way to write/speak Spanish according to the institution that rules and documents the usage and evolution of the Spanish Language in Spain, which is Real Academia Española (aka. RAE).

@tairosonloa
Copy link
Author

Hi! Can I get some eyes in this very small PR (16 lines, translations only), please?

This is impeding some visually impaired friends to properly use the app, effectively prohibiting them the access to a more secure and democratic way to communicate.

cc @marissa-signal @pete-signal @elaine-signal @sashaweiss-signal as I saw you submitted commits updating translations since my PR was opened.

Thank you very much, and I'm sorry if I disturbed you somehow.

@tairosonloa
Copy link
Author

Hello, any updates on this? It's a very small PR of 16 lines, and it has been 2 months now...

Copy link

stale bot commented Aug 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 9, 2024
@tairosonloa
Copy link
Author

Can someone from the team please take a look at this... 😞

@stale stale bot removed the stale label Aug 9, 2024
Copy link

stale bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 9, 2024
@tairosonloa
Copy link
Author

Still waiting for someone to take a look at this

@stale stale bot removed the stale label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant