Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why disable adding labels when creating a new issue? #67

Open
lujun9972 opened this issue Mar 24, 2016 · 1 comment
Open

Why disable adding labels when creating a new issue? #67

lujun9972 opened this issue Mar 24, 2016 · 1 comment

Comments

@lujun9972
Copy link

(defmethod gh-issues-issue-req-to-update ((req gh-issues-issue))
  (let ((assignee (oref req assignee))
        ;; (labels (oref req labels))
        (milestone (oref req milestone))
        (to-update `(("title" . ,(oref req title))
                     ("state" . ,(oref req state))
                     ("body" . ,(oref req body)))))

    ;; (when labels (nconc to-update `(("labels" . ,(oref req labels) ))))
    (when milestone
      (nconc to-update `(("milestone" . ,(oref milestone number)))))
    (when assignee
      (nconc to-update `(("assignee" . ,(oref assignee login) ))))
    to-update))

I noticed that you comemnt out those two pieces of code. But I don't know why?

vermiculus added a commit to vermiculus/gh.el that referenced this issue Feb 17, 2017
@vermiculus
Copy link

It feels like this was a missed ;todo item. Easy fix, anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants