Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pakcage cl is deprecated #109

Open
santoshs opened this issue Apr 16, 2021 · 2 comments
Open

Pakcage cl is deprecated #109

santoshs opened this issue Apr 16, 2021 · 2 comments

Comments

@santoshs
Copy link

I get this warning with native-comp emacs. But I believe this gets printed with vanilla emacs too.

Warning (comp): gh-common.el:30:13: Warning: Package cl is deprecated

also other warnings related to defmethod. Replacing cl with cl-lib and defmethod with cl-defmethod gets rid of most of the warnings expect a few which is listed below.

Compiling file ~/.emacs.d/elpa/gh-20201222.438/gh-common.el at Fri Apr 16 08:35:26 2021
gh-common.el:104:14: Warning: ‘gh-object’ is an obsolete variable (as of
    25.1); use 'gh-object instead
gh-common.el:108:22: Warning: ‘object-p’ is an obsolete function (as of 25.1);
    use ‘eieio-object-p’ instead.
gh-common.el:127:15: Warning: ‘call-next-method’ is an obsolete alias (as of
    25.1); use ‘cl-call-next-method’ instead.
gh-common.el:130:14: Warning: ‘gh-ref-object’ is an obsolete variable (as of
    25.1); use 'gh-ref-object instead
gh-common.el:146:14: Warning: ‘gh-user’ is an obsolete variable (as of 25.1);
    use 'gh-user instead
gh-common.el:153:35: Warning: ‘gh-comment’ is an obsolete variable (as of
    25.1); use 'gh-comment instead

Not an elisp expert, fixing those was not straight forward.

@danielfleischer
Copy link
Contributor

Package is now completely broken after eieio-compat was moved to obsolete in Emacs 29 master.

@colonelpanic8
Copy link
Contributor

Is this not fixed by #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants