Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated properties #1581

Open
wants to merge 16 commits into
base: release-3.0.0
Choose a base branch
from

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Nov 27, 2024

💡 What is the current behavior?

GitHub Issue Number: #N/A, [IX-1601]

🆕 What is the new behavior?

  • ix-action-card: insight and notification variants replaced by outline and filled.
  • ix-card: insight and notification variants replaced by outline and filled.
  • ix-chip: color replaced by chipColor.
  • ix-date-picker:
  • Removed: individual, eventDelimiter.
  • textSelectedDate replaced by i18nDone.
  • done event replaced by dateSelect.
  • ix-datetime-picker:
  • Removed: eventDelimiter.
  • textSelectedDate replaced by i18nDone.
  • done event replaced by dateSelect.
  • ix-event-list: color replaced by itemColor.
  • ix-icon-button: color replaced by iconColor.
  • ix-menu: Removed maxVisibleMenuItems.
  • ix-menu-item: Removed tabIcon.
  • ix-modal: keyboard replaced by closeOnEscape.
  • ix-pill: color replaced by pillColor.
  • ix-push-card: insight and notification variants replaced by outline and filled.
  • ix-select:
    • selectedIndices replaced by value.
    • itemSelectionChange event replaced by valueChange.
  • ix-select-item: value attribute type changed to string.
  • ix-time-picker: Removed individual and showTimeReference.
  • ix-typography: color replaced by textColor.
  • strict typing will not be resolved in this PR
  • Open: Should V3.md be the same as changeset content?
  • Potential Bug: Outline / Filled Variant have a soft secondary subtext (should this be fixed in here?)

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: fc227a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
eslint-config-ix Major
@siemens/ix-angular Major
@siemens/ix-echarts Major
@siemens/ix-aggrid Major
@siemens/ix-react Major
@siemens/ix Major
@siemens/ix-vue Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthiashader matthiashader changed the base branch from main to release-3.0.0 November 27, 2024 06:05
Copy link
Contributor

github-actions bot commented Nov 27, 2024

Report of strict check

src/components/application-header/application-switch-modal/application-switch-modal.tsx
  • src/components/application-header/application-switch-modal/application-switch-modal.tsx(89,11): error TS2564: Property 'config' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'config' has no initializer and is not definitely assigned in the constructor.
src/components/avatar/avatar.tsx
  • src/components/avatar/avatar.tsx(183,13): error TS2322: Type '(ref: HTMLIxDropdownElement) => HTMLIxDropdownElement' is not assignable to type '(elm?: HTMLIxDropdownElement | undefined) => void'.: error TS2322: Type '(ref: HTMLIxDropdownElement) => HTMLIxDropdownElement' is not assignable to type '(elm?: HTMLIxDropdownElement | undefined) => void'.
  • src/components/avatar/avatar.tsx(203,15): error TS2322: Type '(ref: HTMLSlotElement) => HTMLSlotElement' is not assignable to type '(elm?: Element | undefined) => void'.: error TS2322: Type '(ref: HTMLSlotElement) => HTMLSlotElement' is not assignable to type '(elm?: Element | undefined) => void'.
src/components/blind/blind.tsx
  • src/components/blind/blind.tsx(164,15): error TS2322: Type '(ref: HTMLElement) => HTMLElement' is not assignable to type '(elm?: HTMLIxIconElement | undefined) => void'.: error TS2322: Type '(ref: HTMLElement) => HTMLElement' is not assignable to type '(elm?: HTMLIxIconElement | undefined) => void'.
src/components/chip/chip.tsx
  • src/components/chip/chip.tsx(27,14): error TS2564: Property 'el' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'el' has no initializer and is not definitely assigned in the constructor.
  • src/components/chip/chip.tsx(56,11): error TS2564: Property 'icon' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'icon' has no initializer and is not definitely assigned in the constructor.
  • src/components/chip/chip.tsx(80,12): error TS2564: Property 'closeChip' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'closeChip' has no initializer and is not definitely assigned in the constructor.
src/components/date-picker/date-picker.tsx
  • src/components/date-picker/date-picker.tsx(354,26): error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.: error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.
  • src/components/date-picker/date-picker.tsx(549,28): error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.: error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.
  • src/components/date-picker/date-picker.tsx(552,35): error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.: error TS2345: Argument of type '{ from: string | undefined; to: string | undefined; }' is not assignable to parameter of type 'DateChangeEvent'.
src/components/icon-button/icon-button.tsx
  • src/components/icon-button/icon-button.tsx(24,14): error TS2564: Property 'hostElement' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'hostElement' has no initializer and is not definitely assigned in the constructor.
  • src/components/icon-button/icon-button.tsx(32,38): error TS2564: Property 'a11yLabel' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'a11yLabel' has no initializer and is not definitely assigned in the constructor.
  • src/components/icon-button/icon-button.tsx(43,11): error TS2564: Property 'outline' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'outline' has no initializer and is not definitely assigned in the constructor.
  • src/components/icon-button/icon-button.tsx(48,11): error TS2564: Property 'ghost' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'ghost' has no initializer and is not definitely assigned in the constructor.
  • src/components/icon-button/icon-button.tsx(53,11): error TS2564: Property 'oval' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'oval' has no initializer and is not definitely assigned in the constructor.
  • src/components/icon-button/icon-button.tsx(58,11): error TS2564: Property 'icon' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'icon' has no initializer and is not definitely assigned in the constructor.
  • src/components/icon-button/icon-button.tsx(69,11): error TS2564: Property 'iconColor' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'iconColor' has no initializer and is not definitely assigned in the constructor.
  • src/components/icon-button/icon-button.tsx(91,3): error TS2564: Property 'submitButtonElement' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'submitButtonElement' has no initializer and is not definitely assigned in the constructor.
src/components/menu-category/menu-category.tsx
  • src/components/menu-category/menu-category.tsx(43,11): error TS2564: Property 'label' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'label' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-category/menu-category.tsx(48,11): error TS2564: Property 'icon' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'icon' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-category/menu-category.tsx(53,11): error TS2564: Property 'notifications' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'notifications' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-category/menu-category.tsx(58,3): error TS2564: Property 'closeOtherCategories' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'closeOtherCategories' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-category/menu-category.tsx(65,11): error TS2564: Property 'observer' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'observer' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-category/menu-category.tsx(66,11): error TS2564: Property 'menuItemsContainer' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'menuItemsContainer' has no initializer and is not definitely assigned in the constructor.
  • src/components/menu-category/menu-category.tsx(67,11): error TS2564: Property 'ixMenu' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'ixMenu' has no initializer and is not definitely assigned in the constructor.
src/components/modal/modal.tsx
  • src/components/modal/modal.tsx(70,11): error TS2564: Property 'beforeDismiss' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'beforeDismiss' has no initializer and is not definitely assigned in the constructor.
  • src/components/modal/modal.tsx(85,12): error TS2564: Property 'dialogClose' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'dialogClose' has no initializer and is not definitely assigned in the constructor.
  • src/components/modal/modal.tsx(90,12): error TS2564: Property 'dialogDismiss' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'dialogDismiss' has no initializer and is not definitely assigned in the constructor.
  • src/components/modal/modal.tsx(102,12): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/modal/modal.tsx(145,18): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/modal/modal.tsx(194,7): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
  • src/components/modal/modal.tsx(220,7): error TS2531: Object is possibly 'null'.: error TS2531: Object is possibly 'null'.
src/components/pill/pill.tsx
  • src/components/pill/pill.tsx(18,14): error TS2564: Property 'el' has no initializer and is not definitely assigned in the constructor.: error TS2564: Property 'el' has no initializer and is not definitely assigned in the constructor.
src/components/select/select.tsx
  • src/components/select/select.tsx(294,9): error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'HTMLElement'.: error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'HTMLElement'.
  • src/components/select/select.tsx(300,33): error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'Node'.: error TS2345: Argument of type 'HTMLIxDropdownElement | undefined' is not assignable to parameter of type 'Node'.
  • src/components/select/select.tsx(345,5): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.
  • src/components/select/select.tsx(391,5): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/select/select.tsx(438,5): error TS2322: Type '(string | undefined)[]' is not assignable to type 'string[]'.: error TS2322: Type '(string | undefined)[]' is not assignable to type 'string[]'.
  • src/components/select/select.tsx(498,7): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.
  • src/components/select/select.tsx(532,24): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.: error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
  • src/components/select/select.tsx(601,7): error TS2532: Object is possibly 'undefined'.: error TS2532: Object is possibly 'undefined'.
  • src/components/select/select.tsx(676,12): error TS18048: 'item.label' is possibly 'undefined'.: error TS18048: 'item.label' is possibly 'undefined'.
  • src/components/select/select.tsx(780,5): error TS2322: Type 'Promise<HTMLInputElement | undefined>' is not assignable to type 'Promise<HTMLInputElement>'.: error TS2322: Type 'Promise<HTMLInputElement | undefined>' is not assignable to type 'Promise<HTMLInputElement>'.
  • src/components/select/select.tsx(859,23): error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.: error TS2322: Type 'null' is not assignable to type 'DropdownItemWrapper | undefined'.

Copy link

sonarcloud bot commented Nov 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant