Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/drawer|inputgroup): fixed drawer display issue #1561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ridvandmrc
Copy link
Contributor

@ridvandmrc ridvandmrc commented Nov 13, 2024

💡 What is the current behavior?

  • initial drawer display style is none so that child cannot calculate its width or height.
  • because if parent is disable that means that child cannot calculate from DOM

GitHub Issue Number: #1551

🆕 What is the new behavior?

  • Updated drawer style and refactored input-group

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 87e0a0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarcloud bot commented Nov 28, 2024

@ridvandmrc
Copy link
Contributor Author

It has tested and verified with new version.

<ix-drawer>
      <ix-input-group>
        <input type="text" value="input text" />
        <span slot="input-start"><ix-icon name="about" size="16"></ix-icon></span>
      </ix-input-group>
      <ix-input value="test value" >

        <ix-icon name="success" slot="start"></ix-icon>
    </ix-input>
    </ix-drawer>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant