Mark off-boarded collaterals on the dashboard #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valiafetisov
reviewed
Mar 8, 2023
| @@ -11,7 +11,7 @@ | |||
| <CurrencyIcon :currency-symbol="record.symbol" /> | |||
| </div> | |||
| <div slot="ilk" slot-scope="ilk" class="Element"> | |||
| {{ ilk }} | |||
| {{ ilk }} <span v-if="isCollateralOffboarded(ilk)" class="opacity-50"> (off-boarded)</span> | |||
There was a problem hiding this comment.
Nit: we might just use a separate column for that with off-boarded/active label
Comment on lines
+167
to
+182
| async isCollateralOffboarded( | ||
| { rootGetters }: ActionContext<State, State>, | ||
| collateralType: string | ||
| ): Promise<boolean> { | ||
| const network = rootGetters['network/getMakerNetwork']; | ||
| if (!network) { | ||
| return false; | ||
| } | ||
| const typeHex = ethers.utils.formatBytes32String(collateralType); | ||
| const maxCollateralDebt = await getContractValue(network, 'MCD_VAT', 'ilks', { | ||
| parameters: [typeHex], | ||
| variableName: 'line', | ||
| decimalUnits: 'RAD', | ||
| }); | ||
| return maxCollateralDebt.isZero(); | ||
| }, |
There was a problem hiding this comment.
- Please move this function to the appropriate place in the
core - Then, please just call
isCollateralOffboardedinside existingfetchCollateralStatusaction to add the values to the type - Then, you no longer need to pass any other new props to the dashboard, and can just use existing
status.isOffboardedto display the appropriate label
Do you see any problems with this suggestion or why did you have to introduce all those new props and extra types like offBoardedCollaterals array?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #594.
Checklist:
#)