Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change signUp signature to avoid tautology #948

Open
phoenix-ru opened this issue Nov 28, 2024 · 0 comments
Open

Change signUp signature to avoid tautology #948

phoenix-ru opened this issue Nov 28, 2024 · 0 comments
Labels
breaking-change A change will changes that require at least a minor release. enhancement An improvement that needs to be added p2 Nice to have

Comments

@phoenix-ru
Copy link
Collaborator

          You're actually right, it's a weird implementation in https://github.com/sidebase/nuxt-auth/pull/615 which accepts two identical interfaces:

async function signUp(credentials: Credentials, signInOptions?: SecondarySignInOptions, signUpOptions?: SignUpOptions) {

It should be just signUpOptions, will probably move this to a different breaking change

Originally posted by @phoenix-ru in #702 (comment)

@phoenix-ru phoenix-ru added p2 Nice to have enhancement An improvement that needs to be added breaking-change A change will changes that require at least a minor release. labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change will changes that require at least a minor release. enhancement An improvement that needs to be added p2 Nice to have
Projects
None yet
Development

No branches or pull requests

1 participant