Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harvester should import ID-less PASAT files to Import project #362

Open
shippy opened this issue Feb 4, 2020 · 0 comments
Open

harvester should import ID-less PASAT files to Import project #362

shippy opened this issue Feb 4, 2020 · 0 comments

Comments

@shippy
Copy link
Contributor

shippy commented Feb 4, 2020

Right now, harvester raises an error whenever the parsed PASAT DB results in any ID-less output (i.e. files that start with NOID or nan). (This behavior is from db0cf2f in Feb 2018.) The SOP for the ID-less PASAT case is:

  1. check the processed ID-less PASAT file for data,
  2. if data is there, check with site that the PASAT record doesn't belong to an actual ID, otherwise GOTO 4
  3. if it does belong to an actual ID, rename the processed file, upload it under a valid Import ID, and add an exception to special_cases::harvester::ignore_processed_paths for the original NOID name; otherwise GOTO 4
  4. if the data isn't there, or it is a confirmed legit test case, close the issue (and maybe remove the processed file).

See e.g. sibis-platform/ncanda-operations#8145.

The resolution steps are unwieldy and require filesystem manipulation. But we already have a mechanism for sites to fix incorrectly entered subject ID - they just need to do that in the Import project! Therefore, perhaps we shoud allow for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant