Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not treat response as JSON by default #9

Open
w33ble opened this issue Mar 9, 2020 · 0 comments
Open

Should not treat response as JSON by default #9

w33ble opened this issue Mar 9, 2020 · 0 comments
Labels
defect Unexpected error or behavior

Comments

@w33ble
Copy link
Member

w33ble commented Mar 9, 2020

Currently, if you don't specify a resposeType in the config object, it assumes the response is JSON and attempts to call the .json() method.

There's a way to opt out, but passing in a config object of { responseType: 'raw' } (or anything other than json or text).

the default behavior, however, should likely be to just return the raw response. Users can then opt-in to the JSON/Text behavior.
@w33ble w33ble added the defect Unexpected error or behavior label Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect Unexpected error or behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@w33ble