Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or clarify dependency on tus-server #7

Open
jonleighton opened this issue Mar 21, 2024 · 0 comments
Open

Remove or clarify dependency on tus-server #7

jonleighton opened this issue Mar 21, 2024 · 0 comments

Comments

@jonleighton
Copy link

This plugin defines a dependency on tus-server (a Ruby implementation of a Tus server) in the gemspec. However, it never actually requires any files from that gem.

That said, it does implicitly depend on tus-server in this line:

rescue ::Tus::NotFound

That constant is defined in tus-server here.

Therefore, if I use shrine-tus without explicitly requiring tus-server, then I'll get a NameError if I hit an error in this method.

There are two potential solutions:

  1. Remove the dependency on tus-server. This would be my preference - I don't think shrine-tus as a Tus client should care about what server implementation is used. (On my project, we're using tusd, therefore we don't want/need the tus-server gem at all.)
  2. Require tus/errors so that the constant gets defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant