From 483292250282739b26171fbad8593852472f7555 Mon Sep 17 00:00:00 2001 From: Stacey Oue Date: Fri, 6 Sep 2024 12:49:07 -0400 Subject: [PATCH] SHOT-4386: Update min supported logic to avoid dialog pop up (#124) --- engine.py | 5 +++-- info.yml | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/engine.py b/engine.py index 643a867..1941d95 100644 --- a/engine.py +++ b/engine.py @@ -138,10 +138,11 @@ def pre_app_init(self): # check for version compatibility self.vred_version = os.getenv("TK_VRED_VERSION", None) + vred_major_version = self.vred_version[:4] self.logger.debug("Running VRED version {}".format(self.vred_version)) if ( self._version_check( - self.vred_version, + vred_major_version, str(self.get_setting("compatibility_dialog_min_version")), ) > 0 @@ -160,7 +161,7 @@ def pre_app_init(self): "Warning - Flow Production Tracking Toolkit!", msg, ) - elif self._version_check(self.vred_version, "2021.0") < 0 and self.get_setting( + elif self._version_check(vred_major_version, "2021.0") < 0 and self.get_setting( "compatibility_dialog_old_version" ): msg = ( diff --git a/info.yml b/info.yml index f808d7c..85af414 100644 --- a/info.yml +++ b/info.yml @@ -39,7 +39,7 @@ configuration: description: "Specify the minimum Application major version that will prompt a warning if it isn't yet fully supported and tested with Toolkit. To disable the warning dialog for the version you are testing, it is recommended that you set this - value to the current major version + 1." + value to the latest supported version." default_value: 2025 compatibility_dialog_old_version: