Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undercounting for patch success #224

Open
eseidel opened this issue Oct 29, 2024 · 0 comments
Open

fix: undercounting for patch success #224

eseidel opened this issue Oct 29, 2024 · 0 comments

Comments

@eseidel
Copy link
Contributor

eseidel commented Oct 29, 2024

Right now we don't use the queue for sending install successes. Which means that if the user is offline we will not end up billing customers for that install.

https://github.com/shorebirdtech/updater/blob/main/library/src/updater.rs#L635

We should always use the patch event queue IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant