Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overbilling for failed patches #223

Open
eseidel opened this issue Oct 29, 2024 · 3 comments
Open

fix: overbilling for failed patches #223

eseidel opened this issue Oct 29, 2024 · 3 comments

Comments

@eseidel
Copy link
Contributor

eseidel commented Oct 29, 2024

If you install patch 1. Patch 2 then fails to boot (install) and rolls back to patch 1 we will bill you for patch 1 twice (since we report successful install of patch 1 again).

@eseidel
Copy link
Contributor Author

eseidel commented Oct 29, 2024

Clarified with Bryan, this shouldn't happen for automatic rollbacks (which don't download anything new, only revert to a previously booting patch or the unaltered release), only explicit rollbacks (where explicit downloads do happen).

So I may have been mistaken in filing this.

@bryanoltman
Copy link
Contributor

As written, this is not correct. Patch 2 would need to successfully install before failing in order to trigger 1) a patch install success event to be sent and 2) patch 1 to be uninstalled.

@bryanoltman
Copy link
Contributor

Currently the only time where this happens (patch N+1 successfully installs and we later revert back to patch N) is in the case of a rollback of patch N+1, where billing for more than one install of patch N is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants