Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install and download events are not reliably delivered #213

Open
eseidel opened this issue Sep 11, 2024 · 0 comments
Open

fix: install and download events are not reliably delivered #213

eseidel opened this issue Sep 11, 2024 · 0 comments

Comments

@eseidel
Copy link
Contributor

eseidel commented Sep 11, 2024

Right now we have 3 separate places where we send patch events.

The queue:

let result = crate::network::send_patch_event(event, &config);

Within update (download):
let report_result = crate::network::send_patch_event(event, &config);

Within launch success (install):
let report_result = crate::network::send_patch_event(event, &config_copy);

None of them retry. It's also kinda silly to have 3 methods.

We should probably always use the queue, and just have multiple places where we try to flush the queue. We should also probably only remove events on success or queue overflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant