fix: improved error message to provide correct command #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think my only question is if this message is going to go stale (are we going to end up changing the way we invoke this) and if so, should it be held in a constant variable instead of a string 🤷 Regardless, I defer to @bryanoltman here who wrote most of our installers I think. |
|
I think I would prefer to update the script to overwrite the existing installation. I can't imagine a case where someone is trying to run this script but has an installation they want to preserve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #31
Changed error message to include the appropriate command to use if an existing shorebird installation was detected.
Type of Change