fix: default subtitle not working

shiyiya · May 9, 2024 · d024d6e · d024d6e
1 parent 060aa83
commit d024d6e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/core/src/player.ts b/packages/core/src/player.ts
@@ -19,7 +19,7 @@ const defaultOptions = {
   muted: false,
   loop: false,
   volume: 1,
-  preload: '',
+  preload: 'metadata',
   playbackRate: 1,
   playsinline: true,
   lang: 'auto',

diff --git a/packages/ui/package.json b/packages/ui/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@oplayer/ui",
-  "version": "1.3.1",
+  "version": "1.3.2-beta.0",
   "description": "ui plugin for oplayer",
   "type": "module",
   "main": "./dist/index.es.js",

diff --git a/packages/ui/src/components/Subtitle.ts b/packages/ui/src/components/Subtitle.ts
@@ -48,9 +48,16 @@ export class Subtitle {
     this.processDefault(this.options.source)
 
     this.createContainer()
-    this.fetchSubtitle()
     this.loadSetting()
 
+    if (this.currentSubtitle) {
+      if (this.player.isSourceChanging || isNaN(this.player.duration) || this.player.duration < 1) {
+        this.player.once('loadedmetadata', () => this.fetchSubtitle())
+      } else {
+        this.fetchSubtitle()
+      }
+    }
+
     this.player.on(['destroy', 'videosourcechange'], this.destroy.bind(this))
     this.player.on('videoqualitychang', () => {
       if (this.isShow) this.hide()