From e1058a7c71085b02a3d10a16db8732c2b6771051 Mon Sep 17 00:00:00 2001 From: Szczepan Faber Date: Sun, 13 Dec 2020 08:22:00 -0600 Subject: [PATCH] Made release failures easier to recover Currently, it is difficult to recover from failures when the release step fails. For example, we have accidentally published 1.0.0 version some time ago (more info: https://github.com/shipkit/shipkit-changelog/issues/51). Now it is not possible to delete this version. This change reorders the release steps: *first* we tag and release on GitHub (easy to revert), *then* we publish to Gradle plugins portal (harder to revert). This change prevents problems like https://github.com/shipkit/shipkit-changelog/issues/51 and makes them easier to recover from. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a51a63..587921b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -41,7 +41,7 @@ jobs: && github.ref == 'refs/heads/master' && github.repository == 'shipkit/shipkit-changelog' && !contains(toJSON(github.event.commits.*.message), '[skip release]') - run: ./gradlew publishPlugins githubRelease --scan + run: ./gradlew githubRelease publishPlugins --scan env: # Gradle env variables docs: https://docs.gradle.org/current/userguide/build_environment.html#sec:gradle_environment_variables GRADLE_PUBLISH_KEY: ${{ secrets.GRADLE_PUBLISH_KEY }}