Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a languages-contrib package #56

Closed
orta opened this issue Aug 3, 2020 · 4 comments
Closed

Add a languages-contrib package #56

orta opened this issue Aug 3, 2020 · 4 comments

Comments

@orta
Copy link
Contributor

orta commented Aug 3, 2020

Adds a new package, which isn't included by default, which accepts pretty much any language

@octref
Copy link
Collaborator

octref commented Aug 4, 2020

What is that for?

@orta
Copy link
Contributor Author

orta commented Aug 4, 2020

The same infra, but for anything outside of #55

@octref
Copy link
Collaborator

octref commented Aug 21, 2020

Do we need it? I think even with loading all grammars it's not that slow. Maybe for #22 we need it though, but we can also introduce an API which loads grammars on demand.

Now I kinda like these being auto generated weekly:
https://github.com/shikijs/shiki/tree/master/packages/languages/data
https://github.com/shikijs/shiki/blob/master/packages/languages/src/lang.ts

@octref
Copy link
Collaborator

octref commented Aug 26, 2020

Defer until we need it.

@octref octref closed this as completed Aug 26, 2020
antfu added a commit that referenced this issue Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants