description |
---|
All future changes to the Issue criteria page will be logged here. |
Batch 3: #41
- SJIP-11: Introduce new report template
- SJIP-12: Clarify duplication considerations
- SJIP-13: Fix typo
Batch 2: #34
- SJIP-7: Duplication
- SJIP-8: Missing Curcuit Breaker Checks
- SJIP-9: Change Trusted/Restricted Logic
Batch 1: #24
- SJIP-5: Update hierarchy of truth
- SJIP-6: Improve known issue question in contest QA
- Historical decisions are no longer considered sources of truth. They may guide Watsons, but judgments should always be based on rules as they are and mistakes should not be repeated. Private messages are not sources of truth.
- Updated the #iv.-how-to-identify-a-high-issue and #v.-how-to-identify-a-medium-issue sections to better explain what high and medium severity issues are. Repealed the #ii.-criteria-for-issue-severity description.
- Added an exception to the hierarchy of truth for cases where blatant mistakes in a higher source of truth were made.
- Specified opportunity loss and design choices to be out of scope.
- Updated the #vi.-requirements section to require the PoC in more cases and ensure that Watsons need to discover the limitations and constraints of the issue being triggered.
- Rephrased the "Future issues" rule to remove ambiguity.
- Changed words in several places to ensure ease of understanding. Typo fixes.
- Made network liveness our of scope, with an exception of sequencer-like issues if they are preventable and the external admin is restricted in the #vii.-list-of-issue-categories-that-are-not-considered-valid section.
- Addition of CHANGELOG to the docs.
- Addition of rule related to CHANGELOG in the point
Hierarchy of truth
in the #iii.-some-standards-observed section
- Some minor changes in the judging criteria documentation structure
- Added the
Contract Scope:
sub-section under #iii.-some-standards-observed section in the judging criteria. - Added the #vi.-requirements section in the judging criteria: https://docs.sherlock.xyz/audits/judging/judging#vi.-requirements
- Added
Non-Standard tokens:
point in the #vii.-list-of-issue-categories-that-are-not-considered-valid section - Extended the
EIP compliance
point in the #viii.-list-of-issue-categories-that-are-considered-valid
- Added rules for escalations: Broken link
- Added the
External Admin trust assumptions
sub-section under #iii.-some-standards-observed