Rounding issue as the contract does not return accurate value #4

ThembaniDube · 2023-12-10T18:43:26Z

Summary

Using a division sign, does not round up or down and return correct value
Decimals need to be handled in a safe way

Line 160 in 9c8df76

    
           if (asset.useMovingAverage) prices[numFeeds] = asset.cumulativeObs / asset.numObservations;

Line 252 in 9c8df76

return (assetPrice * 10 ** decimals) / basePrice;

Line 275 in 9c8df76

return (assetPrice * 10 ** decimals) / basePrice;

Line 294 in 9c8df76

uint256 price = (assetPrice * 10 ** decimals) / basePrice;

Line 681 in 9c8df76

uint16 numObservations = uint16(movingAverageDuration_ / observationFrequency);

Manual Review

Use Solidity's SafeMath to mitigate these errors