You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For some reason that is way beyond my understanding, this plugin tries to disable bells but enables visual bells instead.
After downloading this repo via vim-plug, I consistently get visual bells after an "illegal" action.
Once I comment it out, the bells are gone again.
The most likely cause of that is https://github.com/sheerun/vimrc/blob/master/plugin/vimrc.vim#L213.
As this repo is also used inside vim-polyglot, this issue extends there unless
letg:polyglot_disabled= ['sensible']
is called explicitly.
I found a solution to this problem, namely adding
setbelloff=all
as line 214.
EDIT: This feature seems to have been accepted to vim in patch 7.4.793, which was made in July 2015. Is it safe to assume that this version is used in clients, or should this call be wrapped in a has query?
I hate the visual bells as they disturb you even more than a normal bell (at least there you can turn off your sound, but try that with a visual feature…), so I hope that that is not an intentional feature.
The comment
" Disable any annoying beeps on errors.
would appear to me as this being accidental.
An alternative, if this was not accidental, would be to offer a configuration option that simply turns visual bells on or off.
Another alternative would be to drop the call creating visual bells and let users add it themselves as I am pretty sure most users do not want visual bells → opt-in.
A fourth alternative is to let users individually call the solution mentioned above → opt-out.
I definitely prefer the opt-in mechanism the most as whoever wants visual bells, can still enable them themselves and whoever doesn't want it does not have to opt-out.
The text was updated successfully, but these errors were encountered:
For some reason that is way beyond my understanding, this plugin tries to disable bells but enables visual bells instead.
After downloading this repo via vim-plug, I consistently get visual bells after an "illegal" action.
Once I comment it out, the bells are gone again.
The most likely cause of that is https://github.com/sheerun/vimrc/blob/master/plugin/vimrc.vim#L213.
As this repo is also used inside vim-polyglot, this issue extends there unless
is called explicitly.
I found a solution to this problem, namely adding
as line 214.
EDIT: This feature seems to have been accepted to vim in patch 7.4.793, which was made in July 2015. Is it safe to assume that this version is used in clients, or should this call be wrapped in a
has
query?I hate the visual bells as they disturb you even more than a normal bell (at least there you can turn off your sound, but try that with a visual feature…), so I hope that that is not an intentional feature.
The comment
" Disable any annoying beeps on errors.
would appear to me as this being accidental.
An alternative, if this was not accidental, would be to offer a configuration option that simply turns visual bells on or off.
Another alternative would be to drop the call creating visual bells and let users add it themselves as I am pretty sure most users do not want visual bells → opt-in.
A fourth alternative is to let users individually call the solution mentioned above → opt-out.
I definitely prefer the opt-in mechanism the most as whoever wants visual bells, can still enable them themselves and whoever doesn't want it does not have to opt-out.
The text was updated successfully, but these errors were encountered: