Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual bell gets enabled through this plugin #4

Open
delvh opened this issue Sep 12, 2021 · 2 comments
Open

Visual bell gets enabled through this plugin #4

delvh opened this issue Sep 12, 2021 · 2 comments

Comments

@delvh
Copy link

delvh commented Sep 12, 2021

For some reason that is way beyond my understanding, this plugin tries to disable bells but enables visual bells instead.
After downloading this repo via vim-plug, I consistently get visual bells after an "illegal" action.
Once I comment it out, the bells are gone again.
The most likely cause of that is https://github.com/sheerun/vimrc/blob/master/plugin/vimrc.vim#L213.
As this repo is also used inside vim-polyglot, this issue extends there unless

let g:polyglot_disabled = ['sensible']

is called explicitly.
I found a solution to this problem, namely adding

set belloff=all

as line 214.
EDIT: This feature seems to have been accepted to vim in patch 7.4.793, which was made in July 2015. Is it safe to assume that this version is used in clients, or should this call be wrapped in a has query?

I hate the visual bells as they disturb you even more than a normal bell (at least there you can turn off your sound, but try that with a visual feature…), so I hope that that is not an intentional feature.
The comment

" Disable any annoying beeps on errors.

would appear to me as this being accidental.

An alternative, if this was not accidental, would be to offer a configuration option that simply turns visual bells on or off.
Another alternative would be to drop the call creating visual bells and let users add it themselves as I am pretty sure most users do not want visual bells → opt-in.
A fourth alternative is to let users individually call the solution mentioned above → opt-out.

I definitely prefer the opt-in mechanism the most as whoever wants visual bells, can still enable them themselves and whoever doesn't want it does not have to opt-out.

@sheerun
Copy link
Owner

sheerun commented Sep 13, 2021

would additional

noerrorbells
novisualbell

be ok?

@delvh
Copy link
Author

delvh commented Sep 13, 2021

As long as it does not display visual bells, I'm fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants