Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline editing #103

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

JoshuaCarter
Copy link

This PR is to enable inline editing for linkable fields.

I originally thought to make a 'stand alone' component that did everything correctly, but the custom modal led to me making a react 'shell component' so that the existing entwine logic could just hook into that. This would up being more complex/hacky than I'd predicted, so you may or may not actually want this merged into the module. No harm in offering (and this could be used as launch-pad for a proper solution).

Let me know your thoughts.

jcarter added 9 commits September 26, 2019 15:14
This serves to place the initial html structure when editing inline
so that the entwine logic can take effect.
Field values are sent as POST vars but these are ignored by SS, instead
the values are stored in JSON format on a 'input[name=Elements]' tag and
because I'm only using the react component to scaffold the entwine
logic we need to manually update this (didn't foresee this).
@gorriecoe
Copy link
Contributor

@JoshuaCarter Would you consider making a separate module for this? As it can then be added to Links suggestions list. You should also know that Shea doesn't maintain this module anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants